|
|
Screenshot_2024-04-11_07-48-19.png (7,131 bytes) |
|
|
What's the part about the PHP warning? I can't tell if that's on topic but would need more details to address any warnings. |
|
|
I mean I don't know if there's a warning or if it's just returning a blank value there. I haven't personally looked at the code that's creating the page title. Either it's been left blank or it's trying to grab the title of a nonexistent thread/etc. |
|
|
case 'newthread': if ($poll == 'yes') { nav($lang['textnewpoll']); } else { nav($lang['textpostnew']); } if ($SETTINGS['subject_in_title'] == 'on') { $threadSubject = '- '.$dissubject; } $dissubject is always blank. |
|
|
Good catch. Needs some review and could be an easy fix. |
|
|
I just commented out the last 3 lines minus the curly bracket on localhost. This seems to more of a case of blindly copypasting things unnecessarily given the file structure, so removing it on the newthread case is safe (I think). Still, if we plan to actually add proper page titles for everything in a future release, perhaps removing this snippet is pointless as it stands. Refactoring the code slightly and adding language things for each page title seems the way forward. |
- Anonymous
