View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000777 | XMB1 | Bugs | public | 2025-04-07 07:13 | 2025-04-17 16:35 |
| Reporter | flushedpancake | Assigned To | miqrogroove | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | resolved | Resolution | fixed | ||
| Product Version | 1.9.8 SP2 | ||||
| Target Version | 1.10.00 | Fixed in Version | 1.10.00 | ||
| Summary | 0000777: Topic/post limit can go up to 32768 | ||||
| Description | https://forums.xmbforum2.com/viewthread.php?tid=777197&goto=search&pid=1376661 mentioned here, given the potential for "not good" things... yeahhhh setting a hardcoded limit to 100 in the admin settings, and forcing it back to default if it exceeds 100 is probably the way to go (also for some reason you can set it to negative numbers) | ||||
| Tags | No tags attached. | ||||
| MySQL Version | |||||
| PHP Version | |||||
| Web Server | |||||
| Browser | |||||
| Flags | |||||
| Original Reporter | |||||
| SVN Revision | |||||
| Git Commit | https://github.com/miqrogroove/xmb/commit/75051d734e69be05a092fc7ca0a2c2a2673a4652 | ||||
| related to | 0000781 | resolved | miqrogroove | It's possible to crash the who's online page |
|
|
So there are two different issues here. I think a reasonable upper limit should be added in v1.10. I don't see a strong reason to change that (very old) behavior in the 1.9 series. More importantly, there is a missing validation call, most obviously in memcp.php and misc.php, where the $tpp is being used without first checking that it's a positive integer. It's supposed to be handled by validateTpp(). That's the part I would like to fix in 1.9.12.09. Then in v1.10 we can either do away with those validation functions or move the calls into the form editing and login routines. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2025-04-07 07:13 | flushedpancake | New Issue | |
| 2025-04-08 06:22 | miqrogroove | Relationship added | has duplicate 0000781 |
| 2025-04-08 06:22 | miqrogroove | Assigned To | => miqrogroove |
| 2025-04-08 06:22 | miqrogroove | Status | new => confirmed |
| 2025-04-08 06:30 | miqrogroove | Target Version | => 1.10.00 |
| 2025-04-14 09:03 | miqrogroove | Severity | minor => major |
| 2025-04-14 09:03 | miqrogroove | Target Version | 1.10.00 => 1.9.12.09 |
| 2025-04-14 09:03 | miqrogroove | Note Added: 0000562 | |
| 2025-04-14 09:05 | miqrogroove | Note Edited: 0000562 | |
| 2025-04-17 15:18 | miqrogroove | Status | confirmed => assigned |
| 2025-04-17 15:42 | miqrogroove | Relationship deleted | has duplicate 0000781 |
| 2025-04-17 15:43 | miqrogroove | Severity | major => minor |
| 2025-04-17 15:43 | miqrogroove | Target Version | 1.9.12.09 => 1.10.00 |
| 2025-04-17 15:43 | miqrogroove | Relationship added | related to 0000781 |
| 2025-04-17 16:35 | miqrogroove | Status | assigned => resolved |
| 2025-04-17 16:35 | miqrogroove | Resolution | open => fixed |
| 2025-04-17 16:35 | miqrogroove | Fixed in Version | => 1.10.00 |
| 2025-04-17 16:35 | miqrogroove | Git Commit | => https://github.com/miqrogroove/xmb/commit/75051d734e69be05a092fc7ca0a2c2a2673a4652 |
