View Issue Details

IDProjectCategoryView StatusLast Update
0000380XMB1Bugspublic2018-01-18 06:09
ReporterJohn Briggs Assigned Tomiqrogroove  
PrioritylowSeveritytrivialReproducibilityalways
Status closedResolutionfixed 
Product Version1.9.11 Beta 1 
Target Version1.9.11.15Fixed in Version1.9.11.15 
Summary0000380: error html output errors in cp files
Descriptionfunction error() does not output with proper html in cp files when prompted. I have patched one area regarding themes portion of cp2.php as an example but this needs to be done though out the admin files regarding error(). It's cosmetic and not a bug.
Steps To ReproduceSimply choose anything that will throw an error in the admin panel and you will see that a html break tag is missing and in many cases no closing table html.
TagsNo tags attached.
MySQL Version
PHP Version
Web ServerApache
BrowserFirefox
Flags
Original Reporter
SVN Revision2722
Git Commit

Activities

2010-04-20 03:50

 

Error1.png (25,365 bytes)   
Error1.png (25,365 bytes)   

2010-04-20 03:51

 

themecp2fixes.txt (1,135 bytes)   
Edit: cp2.php

Find:

error($lang['textthemeimportfail'], FALSE);

Replace With:

error($lang['textthemeimportfail'], false, '</td></tr></table></td></tr></table><br />');

Find:

error($lang['theme_already_exists'], false, '</td></tr></table></td></tr></table>');

Replace With:

error($lang['theme_already_exists'], false, '</td></tr></table></td></tr></table><br />');

Find:

        echo '<tr bgcolor="'.$altbg2.'" class="ctrtablerow"><td>';
        if (!$query) {
            echo $lang['textthemeimportfail'];
        } else {
            echo $lang['textthemeimportsuccess'];
        }
        echo '</td></tr>';
		
Replace With:

        if (!$query) {
			error($lang['textthemeimportfail'], false, '</td></tr></table></td></tr></table><br />');
        } else {
            echo '<tr bgcolor="'.$altbg2.'" class="ctrtablerow"><td>'.$lang['textthemeimportsuccess'].'</td></tr>';
        }
		
Find:

error($lang['delete_all_themes'], false, '</td></tr></table></td></tr></table>');

Replace With:

error($lang['delete_all_themes'], false, '</td></tr></table></td></tr></table><br />');
themecp2fixes.txt (1,135 bytes)   

2010-04-20 03:51

 

Fix1.png (25,381 bytes)   
Fix1.png (25,381 bytes)   

miqrogroove

2010-05-16 08:25

administrator   ~0000260

Setting low priority on this bug because there may be too many other validation errors in the admin panel to pinpoint a problem with one function.

miqrogroove

2017-12-21 16:24

administrator   ~0000360

Patch looks good. Testing now.

miqrogroove

2017-12-21 16:43

administrator   ~0000361

Found a couple extra while I was in there. No time to audit the whole mess. Thank you for the patch.

Issue History

Date Modified Username Field Change
2010-04-20 03:50 John Briggs New Issue
2010-04-20 03:50 John Briggs File Added: Error1.png
2010-04-20 03:50 John Briggs Web Server => Apache
2010-04-20 03:50 John Briggs Browser => Firefox
2010-04-20 03:51 John Briggs File Added: themecp2fixes.txt
2010-04-20 03:51 John Briggs File Added: Fix1.png
2010-04-21 11:19 miqrogroove Status new => acknowledged
2010-05-16 08:25 miqrogroove Note Added: 0000260
2010-05-16 08:25 miqrogroove Priority normal => low
2012-02-15 22:02 miqrogroove Target Version => 1.9.11.14
2017-12-20 07:10 miqrogroove Target Version 1.9.11.14 => 1.9.11.15
2017-12-21 16:24 miqrogroove Assigned To => miqrogroove
2017-12-21 16:24 miqrogroove Status acknowledged => assigned
2017-12-21 16:24 miqrogroove Note Added: 0000360
2017-12-21 16:27 miqrogroove Category Meta => Bugs
2017-12-21 16:27 miqrogroove Product Version 1.9.11.09 => 1.9.11 Beta 1
2017-12-21 16:43 miqrogroove Status assigned => resolved
2017-12-21 16:43 miqrogroove Resolution open => fixed
2017-12-21 16:43 miqrogroove Fixed in Version => 1.9.11.15
2017-12-21 16:43 miqrogroove SVN Revision => 2722
2017-12-21 16:43 miqrogroove Note Added: 0000361
2018-01-18 06:09 miqrogroove Status resolved => closed