View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000380 | XMB1 | Bugs | public | 2010-04-20 03:50 | 2018-01-18 06:09 |
| Reporter | John Briggs | Assigned To | miqrogroove | ||
| Priority | low | Severity | trivial | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.9.11 Beta 1 | ||||
| Target Version | 1.9.11.15 | Fixed in Version | 1.9.11.15 | ||
| Summary | 0000380: error html output errors in cp files | ||||
| Description | function error() does not output with proper html in cp files when prompted. I have patched one area regarding themes portion of cp2.php as an example but this needs to be done though out the admin files regarding error(). It's cosmetic and not a bug. | ||||
| Steps To Reproduce | Simply choose anything that will throw an error in the admin panel and you will see that a html break tag is missing and in many cases no closing table html. | ||||
| Tags | No tags attached. | ||||
| MySQL Version | |||||
| PHP Version | |||||
| Web Server | Apache | ||||
| Browser | Firefox | ||||
| Flags | |||||
| Original Reporter | |||||
| SVN Revision | 2722 | ||||
| Git Commit | |||||
|
2010-04-20 03:50
|
|
|
2010-04-20 03:51
|
themecp2fixes.txt (1,135 bytes)
Edit: cp2.php
Find:
error($lang['textthemeimportfail'], FALSE);
Replace With:
error($lang['textthemeimportfail'], false, '</td></tr></table></td></tr></table><br />');
Find:
error($lang['theme_already_exists'], false, '</td></tr></table></td></tr></table>');
Replace With:
error($lang['theme_already_exists'], false, '</td></tr></table></td></tr></table><br />');
Find:
echo '<tr bgcolor="'.$altbg2.'" class="ctrtablerow"><td>';
if (!$query) {
echo $lang['textthemeimportfail'];
} else {
echo $lang['textthemeimportsuccess'];
}
echo '</td></tr>';
Replace With:
if (!$query) {
error($lang['textthemeimportfail'], false, '</td></tr></table></td></tr></table><br />');
} else {
echo '<tr bgcolor="'.$altbg2.'" class="ctrtablerow"><td>'.$lang['textthemeimportsuccess'].'</td></tr>';
}
Find:
error($lang['delete_all_themes'], false, '</td></tr></table></td></tr></table>');
Replace With:
error($lang['delete_all_themes'], false, '</td></tr></table></td></tr></table><br />'); |
|
2010-04-20 03:51
|
|
|
|
Setting low priority on this bug because there may be too many other validation errors in the admin panel to pinpoint a problem with one function. |
|
|
Patch looks good. Testing now. |
|
|
Found a couple extra while I was in there. No time to audit the whole mess. Thank you for the patch. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-04-20 03:50 | John Briggs | New Issue | |
| 2010-04-20 03:50 | John Briggs | File Added: Error1.png | |
| 2010-04-20 03:50 | John Briggs | Web Server | => Apache |
| 2010-04-20 03:50 | John Briggs | Browser | => Firefox |
| 2010-04-20 03:51 | John Briggs | File Added: themecp2fixes.txt | |
| 2010-04-20 03:51 | John Briggs | File Added: Fix1.png | |
| 2010-04-21 11:19 | miqrogroove | Status | new => acknowledged |
| 2010-05-16 08:25 | miqrogroove | Note Added: 0000260 | |
| 2010-05-16 08:25 | miqrogroove | Priority | normal => low |
| 2012-02-15 22:02 | miqrogroove | Target Version | => 1.9.11.14 |
| 2017-12-20 07:10 | miqrogroove | Target Version | 1.9.11.14 => 1.9.11.15 |
| 2017-12-21 16:24 | miqrogroove | Assigned To | => miqrogroove |
| 2017-12-21 16:24 | miqrogroove | Status | acknowledged => assigned |
| 2017-12-21 16:24 | miqrogroove | Note Added: 0000360 | |
| 2017-12-21 16:27 | miqrogroove | Category | Meta => Bugs |
| 2017-12-21 16:27 | miqrogroove | Product Version | 1.9.11.09 => 1.9.11 Beta 1 |
| 2017-12-21 16:43 | miqrogroove | Status | assigned => resolved |
| 2017-12-21 16:43 | miqrogroove | Resolution | open => fixed |
| 2017-12-21 16:43 | miqrogroove | Fixed in Version | => 1.9.11.15 |
| 2017-12-21 16:43 | miqrogroove | SVN Revision | => 2722 |
| 2017-12-21 16:43 | miqrogroove | Note Added: 0000361 | |
| 2018-01-18 06:09 | miqrogroove | Status | resolved => closed |