View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000285 | XMB1 | Bugs | public | 2009-03-01 07:32 | 2010-01-23 18:18 |
| Reporter | miqrogroove | Assigned To | miqrogroove | ||
| Priority | normal | Severity | minor | Reproducibility | random |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.9.11 | ||||
| Target Version | 1.9.11.02 | Fixed in Version | 1.9.11.01 | ||
| Summary | 0000285: News Ticker Broken by Linefeed Chars | ||||
| Description | Webmaster reports news ticker stopped working after upgrade. I have traced the cause as far as a single LF character causing syntax errors in two of the Javascript string literals being transmitted. | ||||
| Steps To Reproduce | Any news ticker line exceeding 150 chars may be subject to unwanted line wrapping due to a missing $wrap condition that was removed by 0000034. | ||||
| Additional Information | http://forums.xmbforum.com/viewthread.php?tid=774114 | ||||
| Tags | No tags attached. | ||||
| MySQL Version | |||||
| PHP Version | |||||
| Web Server | |||||
| Browser | |||||
| Flags | Javascript | ||||
| Original Reporter | Tidus0 | ||||
| SVN Revision | 1753 | ||||
| Git Commit | |||||
| related to | 0000034 | closed | miqrogroove | Long URLs Can Exceed Line Wrap Limit |
|
|
This behavior can be reproduced by pasting an unbroken word of more than 150 characters, and probably by using certain combinations of BBCode and/or HTML. |
|
2009-03-01 08:18
|
XMB-1.9.11-news-ticker-issue285.patch.txt (950 bytes)
Index: functions.inc.php
===================================================================
--- functions.inc.php (revision 1745)
+++ functions.inc.php (working copy)
@@ -513,11 +513,13 @@
$message = nl2br($message);
$messagearray = preg_split("#<!-- nobr -->|<!-- /nobr -->#", $message);
+ if ($wrap == "yes") {
for($i = 0; $i < sizeof($messagearray); $i++) {
if ($i % 2 == 0) {
$messagearray[$i] = wordwrap($messagearray[$i], 150, "\n", TRUE);
} // else inside nobr block
}
+ }
$message = implode("", $messagearray);
} else {
@@ -526,7 +528,9 @@
smile($message);
}
$message = nl2br($message);
+ if ($wrap == "yes") {
$message = wordwrap($message, 150, "\n", TRUE);
+ }
}
$message = preg_replace('#(script|about|applet|activex|chrome):#Sis',"\\1 :",$message);
|
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-03-01 07:32 | miqrogroove | New Issue | |
| 2009-03-01 07:32 | miqrogroove | Status | new => assigned |
| 2009-03-01 07:32 | miqrogroove | Assigned To | => miqrogroove |
| 2009-03-01 07:32 | miqrogroove | Flags | => Javascript |
| 2009-03-01 07:32 | miqrogroove | Original Reporter | => Tidus0 |
| 2009-03-01 07:50 | miqrogroove | Note Added: 0000161 | |
| 2009-03-01 07:50 | miqrogroove | Reproducibility | have not tried => random |
| 2009-03-01 07:50 | miqrogroove | Projection | none => minor fix |
| 2009-03-01 07:50 | miqrogroove | ETA | none => < 1 day |
| 2009-03-01 07:50 | miqrogroove | Target Version | 1.9.11 => 1.9.11.01 |
| 2009-03-01 08:06 | miqrogroove | Relationship added | related to 0000034 |
| 2009-03-01 08:08 | miqrogroove | Steps to Reproduce Updated | |
| 2009-03-01 08:18 | miqrogroove | File Added: XMB-1.9.11-news-ticker-issue285.patch.txt | |
| 2009-03-01 08:34 | miqrogroove | SVN Revision | => 1753 |
| 2009-03-01 08:34 | miqrogroove | Status | assigned => resolved |
| 2009-03-01 08:34 | miqrogroove | Fixed in Version | => 1.9.11.01 |
| 2009-03-01 08:34 | miqrogroove | Resolution | open => fixed |
| 2009-03-01 09:33 | miqrogroove | Build | => 1.9.11.00 |
| 2009-03-01 11:23 | miqrogroove | Target Version | 1.9.11.01 => 1.9.11.02 |
| 2010-01-23 18:18 | miqrogroove | Status | resolved => closed |