View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000279 | XMB1 | Translation Defects | public | 2009-02-19 17:30 | 2020-10-20 18:17 |
| Reporter | Jonathon | Assigned To | miqrogroove | ||
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.9.8 SP2 | ||||
| Target Version | 1.9.12 | Fixed in Version | 1.9.12 | ||
| Summary | 0000279: Some text not in varible form | ||||
| Description | There are several lines within the cp2.php file that are still written in (in English) instead of being a variable. What I mean is there is a spot where it has the word "Username" instead of something like "$lang['textusername']" and several other spots that I just noticed. I'll try and write-up a diff file to attach here for you guys to see. | ||||
| Tags | No tags attached. | ||||
| MySQL Version | |||||
| PHP Version | |||||
| Web Server | |||||
| Browser | |||||
| Flags | |||||
| Original Reporter | |||||
| SVN Revision | 2786 | ||||
|
|
This seems to be in places of cp.php as well. I'll kinda check through all the files. |
|
|
Okay, let us know what you find. |
|
|
I haven't had a chance to look at this yet; I'll try and look at it tomorrow. Hope there isn't too many occurrences, lol |
|
|
Well, I'm sorry but I wasn't sure how to make a diff file for this so I just attached a very simple instruction set for what need to be done with the cp2.php file. |
|
2009-02-26 21:21
|
Changes 0001.txt (2,569 bytes)
cp2.php changes
------------------------------------------------------------------------------------------------------------------------
lines 2294 to 2297 of revision 1738
Currently read:
<td><strong><font color="<?php echo $cattext?>">Username:</font></strong></td>
<td><strong><font color="<?php echo $cattext?>">Time:</font></strong></td>
<td><strong><font color="<?php echo $cattext?>">URL:</font></strong></td>
<td><strong><font color="<?php echo $cattext?>">Action:</font></strong></td>
They need to be changed ot read:
<td><strong><font color="<?php echo $cattext?>"><?php echo $lang['textusername'] ?>:</font></strong></td>
<td><strong><font color="<?php echo $cattext?>"><?php echo $lang['cptime'] ?>:</font></strong></td>
<td><strong><font color="<?php echo $cattext?>"><?php echo $lang['cpurl'] ?>:</font></strong></td>
<td><strong><font color="<?php echo $cattext?>"><?php echo $lang['cpaction'] ?>:</font></strong></td>
------------------------------------------------------------------------------------------------------------------------
lines 2418 to 2422 of revision 1738
Currently read:
<td><strong><font color="<?php echo $cattext?>">Username:</font></strong></td>
<td><strong><font color="<?php echo $cattext?>">Time:</font></strong></td>
<td><strong><font color="<?php echo $cattext?>">URL:</font></strong></td>
<td><strong><font color="<?php echo $cattext?>">Action:</font></strong></td>
<td><strong><font color="<?php echo $cattext?>">Ip:</font></strong></td>
They need to read:
<td><strong><font color="<?php echo $cattext?>"><?php echo $lang['textusername'] ?>:</font></strong></td>
<td><strong><font color="<?php echo $cattext?>"><?php echo $lang['cptime'] ?>:</font></strong></td>
<td><strong><font color="<?php echo $cattext?>"><?php echo $lang['cpurl'] ?>:</font></strong></td>
<td><strong><font color="<?php echo $cattext?>"><?php echo $lang['cpaction'] ?>:</font></strong></td>
<td><strong><font color="<?php echo $cattext?>"><?php echo $lang['textip'] ?>:</font></strong></td>
========================================================================================================================
English.lang.php changes
------------------------------------------------------------------------------------------------------------------------
And these lines need to be added to the English lang file and then imported:
$lang['cptime'] = 'Time';
$lang['cpurl'] = 'URL';
$lang['cpaction'] = 'Action'; |
|
|
Okay, we can implement textip, texttime, and textusername for 1.9.11. The other phrases will wait until the next version. Changed in SVN at revision 1739. |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2009-02-19 17:30 | Jonathon | New Issue | |
| 2009-02-19 20:48 | Jonathon | Note Added: 0000154 | |
| 2009-02-19 23:09 | miqrogroove | Note Added: 0000156 | |
| 2009-02-19 23:09 | miqrogroove | Status | new => acknowledged |
| 2009-02-26 00:24 | Jonathon | Note Added: 0000157 | |
| 2009-02-26 21:21 | Jonathon | Note Added: 0000158 | |
| 2009-02-26 21:21 | Jonathon | File Added: Changes 0001.txt | |
| 2009-02-26 21:34 | Jonathon | Note Edited: 0000158 | |
| 2009-02-27 05:26 | miqrogroove | Note Added: 0000159 | |
| 2009-02-27 05:26 | miqrogroove | Status | acknowledged => confirmed |
| 2009-03-01 15:34 | miqrogroove | Projection | none => minor fix |
| 2009-03-01 15:34 | miqrogroove | Product Version | 1.9.11 Beta 4 => 1.9.8 SP2 |
| 2020-08-22 14:55 | miqrogroove | Target Version | => 1.9.12 |
| 2020-08-24 10:28 | miqrogroove | Assigned To | => miqrogroove |
| 2020-08-24 10:28 | miqrogroove | Status | confirmed => assigned |
| 2020-08-24 10:48 | miqrogroove | Status | assigned => resolved |
| 2020-08-24 10:48 | miqrogroove | Resolution | open => fixed |
| 2020-08-24 10:48 | miqrogroove | Fixed in Version | => 1.9.12 |
| 2020-08-24 10:48 | miqrogroove | SVN Revision | => 2786 |
| 2020-10-20 18:17 | miqrogroove | Status | resolved => closed |
