View Issue Details

IDProjectCategoryView StatusLast Update
0000171XMB1New Featurespublic2008-11-28 22:08
Reportermiqrogroove Assigned Tomiqrogroove  
PrioritynormalSeveritymajorReproducibilityN/A
Status closedResolutionfixed 
Target Version1.9.11Fixed in Version1.9.11 
Summary0000171: Function Parameter Efficiency Review
DescriptionWe need to take an in-depth look at the XMB style for passing strings to and from function calls. This is something I didn't think of making part of the original attachment system overhaul. Now that it occurs to me, I think XMB does a pretty bad job of handling string variables, especially the ones that get stored as BLOBs.

The PHP language does not have pointer data types in the way all low level languages do. However, PHP does distinguish between pass-by-value and pass-by-reference parameters. Pass-by-value is the default, meaning every string that gets passed to a function has to be copied first. To make matters worse, PHP does not allow expressions to be passed by reference.

Return-by-reference in PHP is a sloppy prospect because no errors are generated if the function is called incorrectly. I will seriously consider writing some new functions that have no return value for the sake of improving the XMB code style.
TagsNo tags attached.
MySQL Version
PHP Version
Web Server
Browser
Flags
Original Reporter
SVN Revision1391

Relationships

related to 0000467 closedmiqrogroove function escape_var() is Misguided 

Activities

miqrogroove

2008-11-24 02:14

administrator   ~0000080

See also earlier revs. 1370, etc.

Issue History

Date Modified Username Field Change
2008-11-18 13:26 miqrogroove New Issue
2008-11-19 01:13 miqrogroove Status new => assigned
2008-11-19 01:13 miqrogroove Assigned To => miqrogroove
2008-11-24 02:14 miqrogroove SVN Revision => 1391
2008-11-24 02:14 miqrogroove Note Added: 0000080
2008-11-24 02:14 miqrogroove Status assigned => resolved
2008-11-24 02:14 miqrogroove Fixed in Version => 1.9.11
2008-11-24 02:14 miqrogroove Resolution open => fixed
2008-11-28 22:08 miqrogroove Status resolved => closed
2011-05-22 02:11 miqrogroove Relationship added related to 0000467