View Issue Details

IDProjectCategoryView StatusLast Update
0000657XMB1Bugspublic2021-05-02 08:01
Reportermiqrogroove Assigned Tomiqrogroove  
PrioritynormalSeveritymajorReproducibilityalways
Status closedResolutionfixed 
Target Version1.9.12.03Fixed in Version1.9.12.03 
Summary0000657: String-to-Number Comparisons in PHP 8
DescriptionOne of the problems with XMB in PHP 8 is the unexpected result of comparing zero to an empty string. Before PHP 8, (0 == "") is true, but now in PHP 8 it is false. This subtle change is screwing up PHP's non-strict variable types in places like index.php where we have:

if ($lastcat != $thing['cat_fid'] ...

In this example the $lastcat is initialized to zero, and $thing['cat_fid'] is explicitly set to an empty string inside function getIndexForums(), which is unfortunate in light of the complete opposite results in different PHP versions now.
TagsNo tags attached.
MySQL Version
PHP Version8.0
Web Server
Browser
Flags
Original Reporter
SVN Revision2989

Relationships

child of 0000649 closedmiqrogroove PHP 8 Compatibility 

Activities

There are no notes attached to this issue.

Issue History

Date Modified Username Field Change
2021-04-11 21:01 miqrogroove New Issue
2021-04-11 21:02 miqrogroove Relationship added child of 0000649
2021-04-11 21:02 miqrogroove Assigned To => miqrogroove
2021-04-11 21:02 miqrogroove Status new => acknowledged
2021-04-12 06:11 miqrogroove Status acknowledged => assigned
2021-04-13 17:39 miqrogroove Status assigned => resolved
2021-04-13 17:39 miqrogroove Resolution open => fixed
2021-04-13 17:39 miqrogroove Fixed in Version => 1.9.12.03
2021-04-13 17:39 miqrogroove SVN Revision => 2989
2021-05-02 08:01 miqrogroove Status resolved => closed