View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 0000374 | XMB1 | Bugs | public | 2010-04-09 20:08 | 2010-12-23 02:02 |
| Reporter | miqrogroove | Assigned To | miqrogroove | ||
| Priority | low | Severity | crash | Reproducibility | random |
| Status | closed | Resolution | fixed | ||
| Product Version | 1.9.10 | ||||
| Target Version | 1.9.11.10 | Fixed in Version | 1.9.11.10 | ||
| Summary | 0000374: Temp Fields Handled Wrong in Legacy Upgrader | ||||
| Description | The upgrade flow of control goes something like this: "Opening XMB Upgrade Template", existing schema is loaded. "Creating temporary fields...", temp fields are added if not already present. "Changing table schemas", diffs are calculated from existing schema, queries are calculated from diffs, then queries are executed. "Dropping temporary fields...", temp fields are deleted. Now look what happens when the temp fields are present before starting the upgrade. | ||||
| Tags | No tags attached. | ||||
| MySQL Version | |||||
| PHP Version | |||||
| Web Server | |||||
| Browser | |||||
| Flags | |||||
| Original Reporter | |||||
| SVN Revision | 2399 | ||||
| Git Commit | |||||
| related to | 0000417 | closed | miqrogroove | Get Rid of the Legacy Upgrader |
|
|
On top of all that, it's using the wrong condition, WHERE pollopts != '' |
|
|
Looks like this was exacerbated by a change in XMB 1.9.9 where they tried to solve the problem by only adding pollopts_temp if it didn't already exist. This was carried into XMB 1.9.10, but is wrong. The existence of pollopts_temp indicates an inconsistent schema, the format of which cannot be predicted. |
|
|
Removed the inner-loop query pattern and added sanity checks while I was in there. |
|
|
There is a syntax error in upgrade.lib.php, pointed out by RichJ at http://forums.xmbforum.com/viewthread.php?tid=775845&goto=search&pid=1370057 |
|
|
Re-patched. Fully tested using XMB 1.9.5, PHP 5.2.14, and MySQL 5.1.47. Ready for release! |
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2010-04-09 20:08 | miqrogroove | New Issue | |
| 2010-05-16 09:13 | miqrogroove | Status | new => assigned |
| 2010-05-16 09:13 | miqrogroove | Assigned To | => miqrogroove |
| 2010-05-16 10:21 | miqrogroove | Note Added: 0000262 | |
| 2010-05-16 12:56 | miqrogroove | Note Added: 0000263 | |
| 2010-05-16 13:48 | miqrogroove | SVN Revision | => 2389 |
| 2010-05-16 13:48 | miqrogroove | Status | assigned => resolved |
| 2010-05-16 13:48 | miqrogroove | Product Version | 1.9.8 SP2 => 1.9.10 |
| 2010-05-16 13:48 | miqrogroove | Fixed in Version | => 1.9.11.10 |
| 2010-05-16 13:50 | miqrogroove | Note Added: 0000264 | |
| 2010-05-16 13:50 | miqrogroove | Resolution | open => fixed |
| 2010-09-10 08:50 | miqrogroove | Note Added: 0000265 | |
| 2010-09-10 08:50 | miqrogroove | Status | resolved => feedback |
| 2010-09-10 08:50 | miqrogroove | Resolution | fixed => reopened |
| 2010-12-11 16:39 | miqrogroove | Status | feedback => assigned |
| 2010-12-11 18:37 | miqrogroove | SVN Revision | 2389 => 2399 |
| 2010-12-11 18:37 | miqrogroove | Note Added: 0000270 | |
| 2010-12-11 18:37 | miqrogroove | Status | assigned => resolved |
| 2010-12-11 18:37 | miqrogroove | Resolution | reopened => fixed |
| 2010-12-23 02:02 | miqrogroove | Status | resolved => closed |
| 2011-01-15 04:48 | miqrogroove | Relationship added | related to 0000417 |
