View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
0000397XMB1Bugspublic2010-12-10 20:162010-12-23 02:02
Reportermiqrogroove Assigned Tomiqrogroove  
PrioritynormalSeverityminorReproducibilityalways
Status closedResolutionfixed 
Product Version1.9.11 
Target Version1.9.11.10Fixed in Version1.9.11.10 
Summary0000397: $topicsnum Logic Incorrectly Minimized
DescriptionThis is the sort of thing I wouldn't find unless I was looking for it specifically.

In forumdisplay.php, we have these leftover components of older versions:

194: $topicsnum = 0;
328: $topicsnum++;
332: if ($topicsnum == 0) {
367: $query = $db->query("SELECT COUNT(tid) FROM ".X_PREFIX."threads WHERE fid='$fid'");
368: $topicsnum = $db->result($query, 0);

It appears as though line 367 is doing nothing but warming up our database servers.

It's time to clean this up and make it easier to read.
Additional InformationBlamed on rev 1556 (XMB 1.9.11 Beta 3):

http://svn.xmbforum.com/wsvn/XMB/xmb19x/trunk/source/forumdisplay.php?op=diff&rev=1556
TagsNo tags attached.
MySQL Version
PHP Version
Web Server
Browser
Flags
Original Reporter
SVN Revision2397

Activities

There are no notes attached to this issue.

Issue History

Date Modified Username Field Change
2010-12-10 20:16 miqrogroove New Issue
2010-12-10 20:28 miqrogroove Projection none => minor fix
2010-12-10 20:28 miqrogroove Product Version => 1.9.11
2010-12-10 20:28 miqrogroove Description Updated
2010-12-10 20:28 miqrogroove Additional Information Updated
2010-12-10 20:30 miqrogroove Status new => confirmed
2010-12-11 13:45 miqrogroove SVN Revision => 2397
2010-12-11 13:45 miqrogroove Status confirmed => resolved
2010-12-11 13:45 miqrogroove Fixed in Version => 1.9.11.10
2010-12-11 13:45 miqrogroove Resolution open => fixed
2010-12-11 13:45 miqrogroove Assigned To => miqrogroove
2010-12-23 02:02 miqrogroove Status resolved => closed